[maybe breaking] Stop using Ember.A()#435
Open
jrjohnson wants to merge 1 commit into
Open
Conversation
Ember's Array prototype extensions are being deprecated soon, and Ember Data has already deprecated them. As part of Ember Data's deprecation work calling Ember.A on a PromiseMany has been deprecated so removing any calls to this on passed values in composable helpers is needed. For the most part the usage of Ember.A here were replaced with native Array.includes which is supported everywhere but IE 11 unfortunately Array.at() does not yet have universal support so I've added a polyfill for that copied from the TC39 proposal.
|
@jrjohnson Do you think you could also remove this toArray call call, since ember-data deprecates its usage ? |
Contributor
Author
|
@sly7-7 I think that probably needs it's own PR because there are a bunch of calls to |
|
@jrjohnson This makes sense, thanks a lot. |
Contributor
Author
|
@snewcomer I see you did the last release here, are you the right person to ping to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Ember's Array prototype extensions are being deprecated soon, and Ember Data has already deprecated them. As part of Ember Data's deprecation work calling Ember.A on a PromiseMany has been deprecated so removing any calls to this on passed values in composable helpers is needed.
For the most part the usage of Ember.A here were replaced with native Array.includes which is supported everywhere but IE 11. This dropping of IE 11 support is why I marked this PR as breaking even though nothing in the API surface changed.
Unfortunately Array.at() does not yet have universal support so I've added a polyfill for that copied from the TC39 proposal.